Feat/nfl trade logic bootstrap - #28
Merged
Merged
Conversation
CalebRose
commented
Oct 19, 2025
CalebRose
commented
Owner
- Adding logic for NFL trades on interface 2.0
- Fixing minor issues
jedibob5
reviewed
Oct 20, 2025
| SeasonID: number; | ||
| WeekID: number; | ||
| Week: number; | ||
| Rank1: string; |
Collaborator
There was a problem hiding this comment.
I feel like we could potentially make this a lot more compact with something like Rankings: map<number, PollRanking>; where the int key is the team's poll position for the given week (1-25), and pollRanking is a struct declared like:
class PollRanking {
TeamID: number;
Votes: number;
FirstPlaceVotes: number;
}
Not sure how complicated it would be to make that change at this stage, so I'm willing to let it stay as-is if preferred.
jedibob5
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.